Re: NetworkManager and NIS

[Robert Love <rml novell com>]

On Tue, 2005-12-13 at 13:11 -0500, Dan Williams wrote:

> Sounds great actually.  One note on the patch: config->nis_domain is set
> with a g_strdup(), but its not freed when the config is unref-ed.  You
> should just need a g_free (config->nis_domain) in nm_ip4_config_unref().
> 
> Do you have gnome commit access?  If not, send an updated patch with
> that change and I'll put it in.

Patch (on top of Stefan's) is attached.

Stefan, I can happily commit too, if needed.

	Robert Love

Index: src/nm-ip4-config.c
===================================================================
RCS file: /cvs/gnome/NetworkManager/src/nm-ip4-config.c,v
retrieving revision 1.6
diff -u -r1.6 nm-ip4-config.c
--- src/nm-ip4-config.c	4 Dec 2005 02:23:29 -0000	1.6
+++ src/nm-ip4-config.c	13 Dec 2005 18:29:21 -0000
@@ -99,6 +99,7 @@
 	config->refcount--;
 	if (config->refcount <= 0)
 	{
+		g_free (config->nis_domain);
 		g_slist_free (config->nameservers);
 		g_slist_foreach (config->domains, (GFunc) g_free, NULL);
 		g_slist_free (config->domains);