Re: signedness of wireless keys.
- From: Dan Williams <dcbw redhat com>
- To: pjones redhat com
- Cc: NetworkManager-list gnome org
- Subject: Re: signedness of wireless keys.
- Date: Mon, 12 Dec 2005 13:48:45 -0500
On Mon, 2005-12-12 at 13:35 -0500, Peter Jones wrote:
> On Mon, 2005-12-12 at 11:02 -0500, Robert Love wrote:
> > Just a thought, as we move to libnm-util, we should settle on a
> > signedness of the char* we use for wireless keys. Sometimes we use
> > char*, sometimes we use unsigned char*. But the bigger problem is that
> > we mix the types via e.g. return values.
> >
> > You can see all of the mismatches if you turn on the appropriate compile
> > flags.
> >
> > Signed or unsigned?
>
> Unsigned.
Sounds good to me unless there are other objections. What kind of
annoys me though is that when doing strlen(), strcmp() and whatnot, all
the standard library calls take signed char, which means a boatload of
casting.
Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]