Re: signal with class offset , but never used in nautilus_file and nautilus_directory

[gachen gachen <pipigachen gmail com>]

Hi,

the problem is that these class functions are not implemented at all...

Br, Chen Gang

On Thu, May 27, 2010 at 12:15 PM, A. Walton <awalton gnome org> wrote:

On Wed, May 26, 2010 at 11:43 PM, gachen gachen <pipigachen gmail com> wrote:
> Hi,
>
> in nautilus-file.c
>     signals[CHANGED] =
>         g_signal_new ("changed",
>                       G_TYPE_FROM_CLASS (class),
>                       G_SIGNAL_RUN_LAST,
>                       G_STRUCT_OFFSET (NautilusFileClass, changed),
>                       NULL, NULL,
>                       g_cclosure_marshal_VOID__VOID,
>                       G_TYPE_NONE, 0);

http://git.gnome.org/browse/nautilus/tree/libnautilus-private/nautilus-file.h#n507

>     signals[UPDATED_DEEP_COUNT_IN_PROGRESS] =
>         g_signal_new ("updated_deep_count_in_progress",
>                       G_TYPE_FROM_CLASS (class),
>                       G_SIGNAL_RUN_LAST,
>                       G_STRUCT_OFFSET (NautilusFileClass,
> updated_deep_count_in_progress),
>                       NULL, NULL,
>                   g_cclosure_marshal_VOID__VOID,
>                       G_TYPE_NONE, 0);

http://git.gnome.org/browse/nautilus/tree/libnautilus-private/nautilus-file.h#n510

> but , none of "changed" and "updated_deep_count_in_progress"  is defined. So
> should we set the class offset to NULL?
>
> the same problem also in nautilus-directory.c , for signal, "files_added",
> "files_changed", "done_loading" and "load_error".

I'm not seeing any problems here. All of the specified signal slots
are there in the class struct. Am I missing something?

-A. Walton

>
> Br, Chen Gang
>
> --
> nautilus-list mailing list
> nautilus-list gnome org
> http://mail.gnome.org/mailman/listinfo/nautilus-list