[Freeze break request] Nautilus: do not put a frame around images that have an alpha plane



Hi,

Attached a patch that makes sure that images don't get a frame.
Currently larger images than 128 pixels will always get framed, but
this can look ugly (see attached screenshot)

Patch has been approved by Alexander Larsson (Nautilus Maintainer).
Can this patch still go in? It's a trivial change and it makes the
desktop look better.

Regards,

Jaap
From bd97abd6133b8400493611052ccb0d0f83b35848 Mon Sep 17 00:00:00 2001
From: Jaap A. Haitsma <jaap haitsma org>
Date: Sat, 5 Sep 2009 12:34:22 +0200
Subject: [PATCH] Don't show frames around images with alpha plane

---
 libnautilus-private/nautilus-file.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libnautilus-private/nautilus-file.c b/libnautilus-private/nautilus-file.c
index cfe5c5b..84d99ac 100644
--- a/libnautilus-private/nautilus-file.c
+++ b/libnautilus-private/nautilus-file.c
@@ -4165,8 +4165,8 @@ nautilus_file_get_icon (NautilusFile *file,
 								 w * scale, h * scale,
 								 GDK_INTERP_BILINEAR);
 
-			/* We don't want frames around small icons */
-			if (!gdk_pixbuf_get_has_alpha(raw_pixbuf) || s >= 128) {
+			/* We don't want frames around images with an alpha plane */
+			if (!gdk_pixbuf_get_has_alpha(raw_pixbuf)) {
 				nautilus_thumbnail_frame_image (&scaled_pixbuf);
 			}
 			g_object_unref (raw_pixbuf);
-- 
1.6.3.3

Attachment: Screenshot.png
Description: PNG image



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]