Re: [PATCH] Don't show frames around images with an alpha plane

[Mark <markg85 gmail com>]

Just so i get it.
Would this image (with your patch) be without a border or with:
http://upload.wikimedia.org/wikipedia/commons/4/47/PNG_transparency_demonstration_1.png
Because i think it would be without and that would certainly make the
icon view look like a mess.

On Fri, Sep 11, 2009 at 6:46 PM, Jaap A. Haitsma <jaap haitsma org> wrote:
> On Thu, Sep 10, 2009 at 14:13, Mark <markg85 gmail com> wrote:
>> Oh, just noticed your confusing me. you have actually patches for both issues.
>
> Sorry for confusing you I thought my email was pretty clear.
> The first patch for small images was already committed.
>
>> In that case. i agree on the patch that fixes the the small images
>> getting scaled but i don't agree on no frame for images with alpha.
>> Just imagine a image with just one transparent pixel somewhere.. would
>> that suddenly be without a frame? would look odd i think. Specially in
>> a big folder with jpeg and png images.
>
> The patch just checks if there is an alpha plane. JPEG images don't
> have an alpha plane so they will get framed. With PNGs an alpha plane
> is an option.  The use case you are referring to can be constructed
> but it seems unlikely to happen in practice. The use case that you
> have some larger sized PNGs with an alpha plane that get incorrectly
> framed occurs much more often.
>
> So I still think this patch should be applied
>
> Jaap
>
>
>
>>
>> On Sun, Sep 6, 2009 at 9:46 PM, Jaap A. Haitsma <jaap haitsma org> wrote:
>>> Very small patch that doesn't show a frame around images with an alpha
>>> plane which makes the images look a lot better
>>>
>>> It's actually a modification of this patch which I committed a wile ago
>>>
>>> commit 2a94803b44010e3c47a9f7b94894fab8d6062abc
>>> Author: Jaap A. Haitsma <jaap haitsma org>
>>> Date:   Sat Jul 18 20:45:05 2009 +0200
>>>
>>>    Fix handling of small images/icons
>>>
>>>    Small images with an alpha plane don't get a frame
>>>    Use different scaling strategy for small images. Small images/icons
>>>    won't get up scaled in default zoom view. They are shown in their actual
>>>    Fixes bug #585186
>>>
>>>
>>> Can I commit the attached patch?
>>>
>>> Jaap
>>>
>>> --
>>> nautilus-list mailing list
>>> nautilus-list gnome org
>>> http://mail.gnome.org/mailman/listinfo/nautilus-list
>>>
>>
>