Re: Patch to support "F" fallback of XDS DND

[James Dietrich <jdietrch fastmail fm>]

On Tue, Nov 17, 2009 at 01:13:40PM +0100, Alexander Larsson wrote:
> On Tue, 2009-10-27 at 20:08 -0400, jdietrch fastmail fm wrote:
> > On Mon, 15 Jun 2009 16:30 +0200, "Alexander Larsson" <alexl redhat com>
> > wrote:
> > > On Sun, 2009-06-14 at 19:38 -0400, James Dietrich wrote:
> > > > As I recently added XDS support to the application I am developing,
> > > > I needed a file manager that also supported XDS. It was a bit
> > > > surprising to discover that nautilus doesn't currently implement
> > > > the full XDS standard (http://www.newplanetsoftware.com/xds/).
> > > > In particular, nautilus doesn't support the "F" fallback of XDS,
> > > > which allows the file manager to receive the data for the dropped
> > > > file via the X server and save the file. This is important to me,
> > > > because my application is run on a remote machine, and cannot save
> > > > files to the local machine. It depends on the "F" fallback to get
> > > > the file saved.
> > > > 
> > > > So I patched nautilus to fully support XDS and opened this bug
> > > > report with a full description. I have also attached the patch and
> > > > a test program. See http://bugzilla.gnome.org/show_bug.cgi?id=585790
> > > > 
> > > > Since I use Debian, I first reported this to the Debian bug tracking
> > > > system. But the package maintainer suggested that it would be better
> > > > to discuss this directly with upstream. So that's what I'm doing.
> > > > I'd love to see this feature included in the upstream source. It would
> > > > certainly be useful to me, as well as to anyone else who uses XDS with
> > > > an app running on a remote machine.
> > > > 
> > > > Questions? Suggestions? Anything else I can do to help?
> > > 
> > 
> > Thank you for the feedback. I've finally taken the time to work on this
> > again, and have attached a new patch to the report in bugzilla:
> > http://bugzilla.gnome.org/show_bug.cgi?id=585790
> > The new patch applies cleanly to nautilus 2.28.1 and 2.29.1.
> 
> Commited to master. Thanks.
> 
> Btw, when testing with dnd.py i didn't get a filename with the raw
> version. Is that a bug or does dnd.py just don't supply one?

Only the XDS version can supply a filename, so it is expected that the
raw version doesn't supply one. In that case a filename is supplied by
nautilus, and I hard-coded it to be "dropped data". Is that what you
were seeing, or was there not any filename at all?

James