Re: Patches needing review

[Christian Neumair <cneumair gnome org>]

El sáb, 03-05-2008 a las 07:41 -0400, A. Walton escribió:
> In an attempt to push the backlog a bit, here's a quick list of
> patches that need review. A lot of  them are tiny issues that we can
> probably go ahead and commit, but I don't like to commit without
> permission so here goes.

Thanks, that really helps a lot! Unfortunately, I am very busy with
non-programming tasks, so I do not really have time to dig through the
bugzilla email flood.

I approved all of the patches, except:

> http://bugzilla.gnome.org/show_bug.cgi?id=350962
> Bug 350962 – Filing cabinet icon is not recognizable

[commented on bugzilla]

> http://bugzilla.gnome.org/show_bug.cgi?id=409038
> Bug 409038 – FSF address is old
> Downright trivial. On top of that, we could get rid of the GTK+ 2.11.0
> check just below it and update the Nautilus copyright year to 2008. I
> can drum up a patch for this if necessary, but I'd just as soon fix
> them all three in one commit.

Yes, it would be great if you could compile and commit a patch, add a
link to the relevant viewvc revision log entry to the bug report and
close it.

> The ultimate goal on top of this would be to sit down and do some real
> 2.24 planning, if anyone can find the time to do so.

We have a compact view, and I implemented basic tab functionality in the
multiview branch. The tab support needs some GUI love, though - possibly
adding a preference whether middle-clicking a file should open it in a
new tab or a new window.

best regards,
 Christian Neumair

-- 
Christian Neumair <cneumair gnome org>