[PATCH] Potentially huge leak because of the usage of the status bar

[Vincent Untz <vuntz gnome org>]

Hi,

Due to the way we use the status bar, we always push messages to the
status bar stack and nearly never pop the messages. So the stack is
growing, and growing, and growing. Which can be bad :-)

I've put a patch on http://bugzilla.gnome.org/show_bug.cgi?id=536968

Attaching the patch to the mail for convenience.

Vincent

-- 
Les gens heureux ne sont pas pressés.

Index: src/nautilus-window.c
===================================================================
--- src/nautilus-window.c	(révision 14232)
+++ src/nautilus-window.c	(copie de travail)
@@ -201,27 +201,16 @@ nautilus_window_ui_update (NautilusWindo
 	gtk_ui_manager_ensure_update (window->details->ui_manager);
 }
 
-static gboolean
-nautilus_window_clear_status (gpointer callback_data)
-{
-	NautilusWindow *window;
-
-	window = NAUTILUS_WINDOW (callback_data);
-
-	gtk_statusbar_pop (GTK_STATUSBAR (window->details->statusbar), 0); /* clear any previous message, underflow is allowed */
-
-	return FALSE;
-}
-
 void
 nautilus_window_set_status (NautilusWindow *window, const char *text)
 {
 	g_return_if_fail (NAUTILUS_IS_WINDOW (window));
 
+	/* clear any previous message, underflow is allowed */
+	gtk_statusbar_pop (GTK_STATUSBAR (window->details->statusbar), 0);
+
 	if (text != NULL && text[0] != '\0') {
 		gtk_statusbar_push (GTK_STATUSBAR (window->details->statusbar), 0, text);
-	} else {
-		nautilus_window_clear_status (window);
 	}
 }