Re: help wanted: Places sidebar selection bug fix

[Christian Neumair <cneumair gnome org>]

Am Donnerstag, den 24.07.2008, 10:21 +0200 schrieb Nelson Benítez León:
>         Dear developers,
>         [..]
>         If you want to fix this issue, you should update the places
>         list model,
>         instead of clearing it and creating a new one. You might have
>         to use a
>         GtkTreeRowReference to keep the old selection.
>         
> 
>  you mean the entire places sidebar items or just the gtk-bookmarks
> ones that are after the separator..? if it's all items would be a big
> refactor code I think..

You will have to track changes to both, so the best approach would be a
complete model refresh, for all of the items.

However, I don't see how it is a huge difference architecturally whether
you just update the bookmarks, or all the items.

You'd ask the volume monitor for a list of volumes, fetch the bookmark
list and iterate through the model, adding/removing/changing items as
neccessary. Whether you use one or both data sources shouldn't matter.

best regards,
 Christian Neumaair

-- 
Christian Neumair <cneumair gnome org>