Re: [PATCH] Information side pane show thumbnail

[Christian Kirbach <christian kirbach googlemail com>]

On Sat, 22 Mar 2008 18:43:47 +0100, Amos Brocco <amos brocco unifr ch>  
wrote:

> the attached patch makes the Information side pane show a thumbnail
> instead of a generic icon (useful with my other patch that makes this
> panel follow current selection)

Thanks for sending in a patch

There are some spurious changes

 -	
 +

and

 -						 NAUTILUS_FILE_ATTRIBUTES_FOR_ICON)) {
 +						 NAUTILUS_FILE_ATTRIBUTES_FOR_ICON)) {	


Frankly, I could not see any changes the patch does to the information  
sidebar. Can you show that with a screenshot?
Also, I think if we use a scaling factor at all, it should be a factor,  
not a divisor, i.e.

	width = GTK_WIDGET (sidebar_title)->allocation.width * PREVIEW_ICON_SCALE  
- TITLE_PADDING;

and PREVIEW_ICON_SCALE = 0.5;

Regards
--
Christian Kirbach
Christian Kirbach googlemail com