Re: [PATCH] Open spatial folder window from browser window

[Alexander Larsson <alexl redhat com>]

On Mon, 2007-11-05 at 09:45 +0000, J�lleter wrote:
> On Mon, 2007-11-05 at 09:00 +0100, Alexander Larsson wrote:
> > On Fri, 2007-11-02 at 22:18 +0100, J�lleter wrote:
> > > Hi,
> > > 
> > > currently it's not possible to open a spatial folder window from a
> > > browser window, while it's possible the other way round. Drilling down a
> > > directory structure in a browser window and then opening a spatial
> > > folder window does make sense, though, in my opinion.
> > > 
> > > The attached patch against svn trunk adds a "Open Folder Window" menu
> > > item to the File menu and appropriate context menus, it also changes
> > > "Open in New Window" to "Browse in New Window" to make the difference
> > > between the two menu items more clear. These changes are only visible if
> > > "Always open in browser windows" is disabled, as we never want to open
> > > spatial folder windows when that option is enabled.
> > > 
> > > I'd also like to add a toolbar button to open a spatial window but that
> > > might be too prominent, so I've omitted it from this patch. However it
> > > would only be visible for people that already use both, spatial and
> > > browser windows, and these users might actually be interested in that
> > > feature.
> > > 
> > > If the patch looks essentially fine, I'll port it to the gio-branch.
> > 
> > Yeah, i think so. On thing perhaps:
> > "Open a Nautilus folder window for the displayed location"
> > 
> > I dunno if it really makes sense to mention Nautilus in the ui like
> > that.
> 
> I've removed 'Nautilus' from the description now. The reason I've added
> it in the first place was the description of the "New Window" action:
> "Open another Nautilus window for the displayed location". We might want
> to change it there, too.

Yeah, i think so.

> Updated patch for trunk and gio-branch is attached, ok to commit?

Please do.