Re: It should be easier for a user to set a application as default mime opener

[Alexander Larsson <alexl redhat com>]

On Sat, 2007-04-07 at 13:51 +0200, lupus wrote:
> This patch extends the "Open with..." dialog. So that you can set it as
> default mime handler.
> 
> 
> Since a picture says more then a thousand words:
> http://bugzilla.gnome.org/attachment.cgi?id=85713
> 
> patch at:
> http://bugzilla.gnome.org/show_bug.cgi?id=422100

I agree with mtp on the labels. The top label should be fixed to say
"Open %filename with:", and the checkbox label something like:

Always open files of type "%type" files with %application

I don't think the checkbox sensitivity matters, because the "open"
button is insensitive, and it applies on open.

Some code comments:
Please avoid whitespace (newlines) changes, and don't remove the
brackets in:
-	if (!app) {
+	if (!app)
 		eel_show_error_dialog (_("Could not add application"),
 				       _("Could not add application to the application database"),
 				       GTK_WINDOW (dialog));
-	}
-
+

Also, there are some spaces before paranthesis missing.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lonely voodoo firefighter gone bad. She's a virginal communist 
journalist prone to fits of savage, blood-crazed rage. They fight crime!