Re: patch nag: handle CORBA errors
- From: Alexander Larsson <alexl redhat com>
- To: Christian Neumair <chris gnome-de org>
- Cc: nautilus-list gnome org, Frederic Crozat <fcrozat mandriva com>
- Subject: Re: patch nag: handle CORBA errors
- Date: Thu, 14 Sep 2006 21:53:24 +0200
On Thu, 2006-09-14 at 20:28 +0200, Christian Neumair wrote:
> Am Donnerstag, den 14.09.2006, 10:31 +0200 schrieb Alexander Larsson:
> > On Wed, 2006-09-13 at 17:34 +0200, Frederic Crozat wrote:
> > > Le mercredi 13 septembre 2006 à 10:21 +0200, Alexander Larsson a écrit :
> > > > On Tue, 2006-09-12 at 21:23 +0200, Christian Neumair wrote:
> > > > > See bug http://bugzilla.gnome.org/show_bug.cgi?id=46664 . We sometimes
> > > > > even access the result data without checking for CORBA errors, which is
> > > > > a no-no and may well be the cause of bug
> > > > > http://bugzilla.gnome.org/show_bug.cgi?id=353629 .
> > > >
> > > > Yes, that looks good. Please commit.
> > > >
> > > > I don't think it will fix the bug though, all metadata accesses through
> > > > corba are in-process these days, so we generally shouldn't be getting
> > > > any corba failures.
> > >
> > > I've tried to apply this patch on nautilus 2.16.0 and got the following
> > > assert :
> > Ugh, that doesn't look good. Lets not apply this patch then. Manny,
> > would you like to look into the issue with the patch?
> I committed it after changing the g_assert, cf. the referenced bugzilla
> URI, comment 10. Thanks for the quick testing and feedback Frederic! :)
g_assert (!found || error != NULL);
Is that really right? "!found || error != NULL" is the same as "!(found
&& error == NULL)", so we assert if we find something and get no error?
What is it meant to do? The original looked more right to me, either we
found something, or we have an error.
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a superhumanly strong small-town paramedic looking for 'the Big One.'
She's a green-fingered hypochondriac safe cracker with her own daytime radio
talk show. They fight crime!
] [Thread Prev