Re: Final patch for #330298 (icons get rearranged and overlap)

[Alexander Larsson <alexl redhat com>]

On Wed, 2006-11-08 at 11:12 -0600, Federico Mena Quintero wrote:
> On Wed, 2006-11-08 at 11:33 +0100, Alexander Larsson wrote:
> 
> > > Did you test this a lot, because I just tried the released tarball with
> > > this in, and it moves icons around that i've never ever had a problem
> > > with before.
> > 
> > To be more exact, with the icons ordered by "clean up by name", each
> > time i log in all the "virtual" icons like home, computer, trash and
> > volumes are moved to the "end", with gaping holes where they used to be.
> > 
> > Reverting the patch fixes it.
> > 
> > Didn't you see this in testing? Did something else change?
> 
> Wow, strange.
> 
> I tested this and it doesn't happen for me.
> 
> I'm not running stock CVS, but rather GNOME 2.16 from OpenSuse 10.2...
> let me do a full diff to see if there's anything missing.

I'm reverting this for now, as I've not seen much problems before but
with it things is constantly wrong. We'll have to look into this in
2.17.x.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a leather-clad flyboy paranormal investigator plagued by the memory of 
his family's brutal murder. She's a disco-crazy French-Canadian snake charmer 
with the power to bend men's minds. They fight crime!