Re: [PATCH] Display URI's sanely in 'Connect to Server'
- From: Nate Nielsen <nielsen-list memberwebs com>
- To: Martin Wehner <martin wehner gmail com>
- Cc: Nautilus List <nautilus-list gnome org>
- Subject: Re: [PATCH] Display URI's sanely in 'Connect to Server'
- Date: Wed, 22 Mar 2006 20:40:23 +0000 (GMT)
Martin Wehner wrote:
> I've only looked superficially at the patch so far, but here's what I
> noticed:
>
> * It doesn't apply cleanly anymore.
> * It violates the styleguide by omitting the brackets for if statements
> with one-line blocks.
> * Shouldn't it present the Public FTP type UI when the current URI is an
> anonymous one? Currently it just pre-fills the username entry with
> "anonymous".
Thanks. Made the above changes:
http://bugzilla.gnome.org/attachment.cgi?id=61777
Cheers,
Nate
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]