Re: [PATCH] Display URI's sanely in 'Connect to Server'

On Mon, 2006-03-20 at 19:52 +0000, Nate Nielsen wrote:
> Is it a good time to commit this?

In general I see no reason why this should wait till 2.16. It doesn't
introduce new strings and the current behaviour doesn't seem to be
documented anywhere.
I've only looked superficially at the patch so far, but here's what I

* It doesn't apply cleanly anymore.
* It violates the styleguide by omitting the brackets for if statements
with one-line blocks.
* Shouldn't it present the Public FTP type UI when the current URI is an
anonymous one? Currently it just pre-fills the username entry with


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]