Re: Overlapping icons, again

[Alexander Larsson <alexl redhat com>]

On Wed, 2006-05-31 at 16:01 -0500, Federico Mena Quintero wrote:
> Hi,
> 
> I finally found the reason why volume icons overlap in the desktop
> (http://bugzilla.gnome.org/show_bug.cgi?id=330298)
> 
> finish_adding_new_icons() was ignoring all lazily-positioned icons when
> filling up the PlacemenGrid.  This caused the overlaps.  The fix is to
> make icon_set_position() turn off that flag in the icon.
> 
> Also, once a lazily-positioned icon was moved to avoid overlaps, we
> weren't emitting icon_position_changed so that the higher-level code
> would save the new position metadata.  This caused potential overlaps
> when restarting Nautilus.
> 
> Is this OK to commit?
> 
> [This needs a little change to apply to Manny's latest version of
> nautilus-icon-container.c, which doesn't have separate scaling values
> for x/y, but that's a trivial change I'll make when applying the patch.]

I thought this bug was fixed already? 
Manny, whats your opinion on this?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a sword-wielding overambitious jungle king with a winning smile and a way 
with the ladies. She's a plucky hypochondriac wrestler looking for love in all 
the wrong places. They fight crime!