Re: New GBookmarkFile API in GLib 2.12

[Emmanuele Bassi <ebassi gmail com>]

Hi Xavier;

On Wed, 2006-07-12 at 20:20 +0200, Xavier Claessens wrote:
> On mer, 2006-07-12 at 16:38 +0100, Emmanuele Bassi wrote:
> > On Wed, 2006-07-12 at 17:17 +0200, Xavier Claessens wrote:

> After reading the spec and the GLib's implementation I have more
> questions:
> 
> - GBookmarkFile doesn't seems to have change notification. I guess
> nautilus has to use gnome_vfs_monitor_add() and reload the file when
> modified. Gtk will do the same kind of thing...

The GtkFileSystemUnix implementation that comes with GTK+ will not
monitor the shortcuts storage, while the gnome-vfs implementation that
comes with libgnomeui should monitor the shortcuts storage.

The separation is needed until we can move gnome-vfs (or its successor)
below GTK+.

>  What about having a
> GtkBookmarkFile API specialised for shortcuts used by GtkFileChooser and
> nautilus-places-sidebar (and more Gtk applications) ?

I don't think it's a good idea, exactly because we will already need two
different implementations.

> - When adding a new bookmark we have to specify for which application it
> is. Nautilus can say "nautilus" but what will GtkFilechooser say ?

The default is the application's name, as specified by
g_set_application_name().

>  I
> think it's an useless information in the case of shortcuts like in
> GtkFileChooser.

On the contrary: we can have application-specific bookmarks.

I usually want Gimp to have shortcuts to my Pictures, Photos and
Backgrounds folders, while I'd like SoundJuicer and Muine to have just
the Music shortcut.  Nautilus, on the other hand, should show them all.

> - What can be done for porting old ~/.gtk-bookmark to the new file
> format ?

Some code for converting the old format (which is just URI + user
defined name) is a trivial addition; since the FileChooser can only
store folders, we can assign the inode/folder MIME type as default and
the application name could be set to Nautilus, as the default MIME
handler for folders.

>  If nothing is done the user will lose all his bookmarks.

Quite obviously.

Ciao,
 Emmanuele.

-- 
Emmanuele Bassi,  E: ebassi gmail com
W: http://www.emmanuelebassi.net
B: http://log.emmanuelebassi.net