Re: "empty trash" bar

[Alexander Larsson <alexl redhat com>]

On Thu, 2006-12-14 at 23:28 +0100, Paolo Borelli wrote:
> This patch adds an extra bar (similar to the ones os search and of
> burn://) to the Trash directory.
> 
> screenshot: http://www.gnome.org/~pborelli/nautilus-trash-bar.png
> 
> I think it looks cool and is way more useful than having the "empty
> trash" button in the Info side pane, since I rarely have the sidepane
> open. Beside it's consistent with other contextual actions like "Burn
> CD".
> 
> 
> About the implementation: it was a bit tricky to figure out the right
> layer of abstraction where to plug this in... I decided to make a new
> "nautilus-trash-bar" object that simply knows how to empty the trash
> (it's just a matter of calling nautilus_file_operations_empty_trash)
> instead of making it emit a signal, given that the "empty trash" menu
> item is implemented at the directory-view level and not at the
> nautilus-window level. It is also the same thing that the "empty trash"
> in the side pane does, so I am not making thing worse ;-)
> 
> Speaking of the sidepane: the attached patch also removes the "empty
> trash" button from the sidepane since IMHO it is redundant (and the code
> there it's also unnecessarily complicated, given it tries to handle
> confirmation, but that is already taken care of). This part of the patch
> is orthogonal to the bar, so if you want to keep the button in the pane,
> this part can simply be dropped.

Makes sense to me.

> If you agree with removing the button, maybe we should do the same for
> "Burn".

Yeah.

Please commit.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a world-famous Jewish Green Beret on the edge. She's a green-fingered 
insomniac archaeologist who believes she is the reincarnation of an ancient 
Egyptian queen. They fight crime!