Re: Patch to fix #321819

On Mon, 2006-08-21 at 16:58 -0400, Rodney Dawes wrote:
> Hey guys,
> The emblem size choosing logic in Nautilus is rather problematic at the
> moment, allowing the smallest size of the emblem to be the same size as
> the icon itself, that the emblem is being attached to. The attached
> patch fixes this by using a minimum size of half the icon size, for the
> emblem size, allowing more appropriately sized icons to be used, and
> allowing theme authors to put correctly sized icons in their themes'
> emblems directories, rather than having to kluge around having icons
> that are actually smaller than the theme says they are.
> Can I please get this committed for 2.16? Thanks.

I'm not sure the icon theme spec ever said that the icons have to be
exactly the size the directory specified. They just were designed for
that size. Thats how the emblems in nautilus always worked, instead of
deciding a specific size for the emblems they were designed for a
particular target size.

Even if we want to change this I'm not sure the best time to do so is
when we're hard code frozen. Won't this break every currently working
themed emblem?

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a short-sighted drug-addicted jungle king who hangs with the wrong crowd. 
She's a time-travelling streetsmart mercenary with a flame-thrower. They fight 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]