Am Montag, den 26.09.2005, 11:06 +0200 schrieb Alexander Larsson: > On Tue, 2005-09-20 at 18:53 +0200, Christian Neumair wrote: > > Am Montag, den 19.09.2005, 15:06 +0200 schrieb Alexander Larsson: > > > On Wed, 2005-09-07 at 23:55 +0200, Christian Neumair wrote: > > > > Also covered by bug 116217 [1]. Since users typically set this once, I > > > > think it would be quiet nice to give instant feedback to show them what > > > > they actually changed. > > > > > > > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=116217 > > > > > > > > > - > > > - /* We don't invalidate the files in desktop, since they are always > > > - up to date. (And we don't ever want to mark them invalid.) */ > > > + nautilus_directory_force_reload_internal (NAUTILUS_DIRECTORY (desktop), > > > + nautilus_file_get_all_attributes ()); > > > } > > > > > > Why did you change this? I don't believe this should be needed, and it > > > worries me. I don't remember all the details about > > > NautilusDesktopIconFile exactly, but I don't think invalidating > > > attributes for them are right at all, and i'm not sure they'll ever be > > > validated again. > > > > Good question. I blindly did it, because I thought that the desktop > > directory would only pick up the removal of the old files from the > > desktop if all of them are invalidated. I was wrong. The attached patch > > seems to work as well, although I don't fully understand how exactly all > > the old files are removed from the desktop. The new ones are correctly > > added of course, because the "files-added" signal is proxied. > > Looks good. Please commit. Done. -- Christian Neumair <chris gnome-de org>
Attachment:
signature.asc
Description: This is a digitally signed message part