Re: [PATCH] Commit rename changes on icon click

[Alexander Larsson <alexl redhat com>]

On Tue, 2005-09-20 at 18:31 +0200, Christian Neumair wrote:
> Am Montag, den 19.09.2005, 15:50 +0200 schrieb Alexander Larsson:
> > On Sun, 2005-09-11 at 00:26 +0200, Christian Neumair wrote:
> > > The attached patch fixes bug 309162 [1].
> > > 
> > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=309162
> > 
> > This breaks the initial intent of the code, which is that if you click
> > on the icon you're renaming (e.g. if you miss when selecting in the
> > rename widget) you exit rename mode. 
> 
> Hrm I never miss widgets I want to click. Is that a huge issue for
> visually impaired people? If it is, we should probably do the same for
> the lower end of the entry as well. I fail to see why one should click
> the middle of the icon while renaming to select anything.

I'm not sure why it was done like that, but it my main concern is that
your patch doesn't really fix the problem fully.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an unconventional skateboarding werewolf on the edge. She's a virginal 
green-skinned angel with an incredible destiny. They fight crime!