Re: [PATCH] Commit rename changes on icon click

[Alexander Larsson <alexl redhat com>]

On Sun, 2005-09-11 at 00:26 +0200, Christian Neumair wrote:
> The attached patch fixes bug 309162 [1].
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=309162

This breaks the initial intent of the code, which is that if you click
on the icon you're renaming (e.g. if you miss when selecting in the
rename widget) you exit rename mode. 

Of course, its hard to get the rename done before creating the dnd icon
if we delay renaming until the motion event that starts the dnd since
the rename is asynchronous. In fact, even with your patch this is broken
if you drag quickly enough.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an oversexed albino househusband searching for his wife's true killer. 
She's a cosmopolitan mute cab driver descended from a line of powerful 
witches. They fight crime!