Re: [PATCH] Nautilus Places sidebar URI dropping

[Alexander Larsson <alexl redhat com>]

On Tue, 2005-10-11 at 13:11 +0200, Christian Neumair wrote:
> Am Montag, den 10.10.2005, 16:23 +0200 schrieb Luca Ferretti:
> > Il giorno sab, 08/10/2005 alle 15.42 -0500, Travis Watkins ha scritto:
> > > On 10/7/05, Christian Neumair <chris gnome-de org> wrote:
> > > > > Not true. Better, it seems bugged. Try to middle-clic and drag an item
> > > > > (/f over a shortcut in Places sidebar, them select "Cancel" from
> > > > > popup-menu. This don't cancel the action, but will copy the item. Copy,
> > > > > Move and Link works fine, instead.
> > > >
> > > > Maybe you could rephrase your comment?
> > > 
> > > I think he is trying to say that you can't cancel a middle-click DnD
> > > action. If you click cancel it will copy the file anyway.
> > 
> > Doh! Yeah, this is what I meant. Sorry. 
> 
> OK, updated patch attached.

Drag motion over empty area at bottom doesn't allow you to create a
new bookmark.

Would be nice if it handled text/uri-list too, not only
NAUTILUS_ICON_DND_GNOME_ICON_LIST_TYPE. As drops from non-nautilus are
that type.

+static unsigned int
+get_bookmark_index_at_path (GtkTreeView *tree_view,
+			    GtkTreePath *bookmark_path)

This looks fragile. Why not put the index in the store instead?



+static void
+drag_motion_callback (GtkTreeView *tree_view,

This can use pos and action undefined when setting the status.
It leaks path.
It shouldn't continue to run if (!sidebar->drag_data_received). But it
should probably call gdk_drag_status() in drag_data_received_callback.

+	current_event = gtk_get_current_event ();
+	if (current_event == NULL || current_event->type != GDK_DROP_START) {

Why is this event type check needed? It looks kind of weird.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a time-tossed ninja filmmaker on the hunt for the last specimen of a 
great and near-mythical creature. She's a strong-willed African-American soap 
star with only herself to blame. They fight crime!