Re: [PATCH] Port GtkTreeView-style typeahead to NautilusIconContainer

[Jürg Billeter <j bitron ch>]

On Die, 2005-10-18 at 12:41 +0200, Alexander Larsson wrote:
> On Mon, 2005-10-03 at 16:09 +0200, Jürg Billeter wrote:
> > Attached patch replaces the previous typeahead implementation of
> > NautilusIconContainer by a port of the implementation of GtkTreeView. It
> > is heavily based on that code, just adapted to fit in nautilus. This
> > adds the visible text search entry and the arrow keys / mouse wheel will
> > work as in GtkTreeView.
> > 
> > This might cause usability issues as the arrow keys behave differently
> > when in typeahead mode. Besides that, I don't know whether this
> > behaviour is ok when used on the desktop.
> > 
> > This patch is intended to be applied in line with
> > http://mail.gnome.org/archives/nautilus-list/2005-April/msg00226.html
> > 
> > Any comments?
> 
> I changed some formating and fixed a few bugs and commited this, with
> the matched listview patch. Thanks a lot.

Thanks for reviewing.

> I think it is right that we use the same typeahead implementation in all
> the desktop, and I think this is nicer than the old one. However, I'm
> not sure about having enter activate the selected file while the
> typeahead is up. Right now, the only way to do anything but activating a
> file when you've searched to it (for instance up/down or range select
> using shift) is to wait for 5 seconds for the timeout or press escape.
> 
> Maybe we should make the initial return just hide the typeahead, since
> that is much easier to find than escape?

Not sure what's the right way to go here. Modifying the return key
behavior may cause two problems: One problem is the one mentioned by
Matthew Thomas, pressing return at the moment the timeout is reached
would activate the item - probably unintentional. The other one is that
it would be inconsistent with the file chooser - IMO we should avoid
that as much as possible.

Jürg

-- 
Jürg Billeter <j bitron ch>