Re: [PATCH] Port GtkTreeView-style typeahead to NautilusIconContainer

[Alexander Larsson <alexl redhat com>]

On Mon, 2005-10-03 at 16:09 +0200, Jürg Billeter wrote:
> Attached patch replaces the previous typeahead implementation of
> NautilusIconContainer by a port of the implementation of GtkTreeView. It
> is heavily based on that code, just adapted to fit in nautilus. This
> adds the visible text search entry and the arrow keys / mouse wheel will
> work as in GtkTreeView.
> 
> This might cause usability issues as the arrow keys behave differently
> when in typeahead mode. Besides that, I don't know whether this
> behaviour is ok when used on the desktop.
> 
> This patch is intended to be applied in line with
> http://mail.gnome.org/archives/nautilus-list/2005-April/msg00226.html
> 
> Any comments?

I changed some formating and fixed a few bugs and commited this, with
the matched listview patch. Thanks a lot.

I also filed GtkTreeView bugs for the bugs i found reviewing the adapted
code: http://bugzilla.gnome.org/show_bug.cgi?id=319151

I think it is right that we use the same typeahead implementation in all
the desktop, and I think this is nicer than the old one. However, I'm
not sure about having enter activate the selected file while the
typeahead is up. Right now, the only way to do anything but activating a
file when you've searched to it (for instance up/down or range select
using shift) is to wait for 5 seconds for the timeout or press escape.

Maybe we should make the initial return just hide the typeahead, since
that is much easier to find than escape?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a deeply religious umbrella-wielding senator She's a chain-smoking 
foul-mouthed Hell's Angel married to the Mob. They fight crime!