Re: [PATCH] Use GtkIconChooser for properties window

[Luca Ferretti <elle uca libero it>]

Il giorno mar, 04/10/2005 alle 10.38 +0200, Christian Neumair ha
scritto:
> The attached patch is on bugzilla [1] for some weeks now, and
> unfortunetely didn't get any feedback - so I'm posting it here. It makes
> Nautilus use an icon chooser for image selection in the file properties
> window and consolidates the "custom image" buttons into the image
> button.

It seems to me a good implementation. Maybe a tooltip ("Clic to change
the icon for this item") for button and a11y stuff (if needed) could be
useful. And maybe a tooltip for Revert button too (or a different
label?)

Just a doubt: put a .desktop file on desktop (i.e. drag a launcher from
Application menu), then change its icon. Now try to revert this change.
You can't 'cause the icon was changed directly in .desktop file, not in
Nautilus metadata. Is this correct?

And please note that while you are selecting an image all nautilus
windows are locked. Transient?

>  I've found no appealing way of using a GtkImage as preview
> widget, it always looks kind of squeezed on the right edge. This makes
> the icon selection consistent with the "gnome-about-me" preferences
> dialog.

Well an image preview could be really really useful.


PS Maybe change the UI of dialog to add a shortcut for
icon-chooser-button?

        _Name: [__________________]
        _Icon:  ---------------
               |               |
               |               |
               |               |
               |               |
               |_______________|