Re: [PATCH] Improve activation behavior of multiple files, part 1
- From: Alexander Larsson <alexl redhat com>
- To: Christian Neumair <chris gnome-de org>
- Cc: nautilus-list gnome org
- Subject: Re: [PATCH] Improve activation behavior of multiple files, part 1
- Date: Fri, 25 Nov 2005 09:49:08 +0100
On Thu, 2005-11-24 at 23:54 +0100, Christian Neumair wrote:
> On Do, 2005-11-24 at 11:51 +0100, Alexander Larsson wrote:
> > I made some changes that I think are correct and commited this. However
> > this is some tricky code. I'd appreciate if you tested it a bit too.
>
> Seems to work like a charm up to now. Maybe you could describe what
> precisely you changed, so that others, including me, can learn from
> you? :).
I don't remember all the details. The most important one was getting the
handling of all callbacks getting called from inside
nautilus_file_list_call_when_ready case right. I also simplified the
handling of the list refcounts by ignoring the lists argument in
activate_activation_uris_ready_callback, as it can come both from the
when_ready callback or be called from activation_drive_mounted_callback,
with different ownership models.
For the details, you could just diff the final code with your code.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's an impetuous flyboy inventor on the edge. She's an enchanted kleptomaniac
snake charmer married to the Mob. They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]