Re: [PATCH] Manage note sidepane by nautilus-clipboard

[Christian Neumair <chris gnome-de org>]

Am Dienstag, den 24.05.2005, 15:14 -0600 schrieb Dave Camp:
> Perhaps the public interface should have an add_editable() and an
> add_text_view()?

Well since we basically do exactly the same on both of them (except for
their different API) I thought it would be a good idea to merge this
code.
So in other words you want completely different callbacks for both
types?

> On Sat, 2005-05-21 at 15:34 +0200, Christian Neumair wrote:
> > After applying this patch, the note sidepane will be managed by
> > NautilusClipboard. NautilusClipboard used to be only usable for
> > GtkEditables. I've modified it to also take GtkTextViews. One may ask
> > him or herself why GtkTextView can't be turned into a GtkEditable, but
> > there are in fact design hurdles [1].
> > I don't know whether you like the way the callbacks are organized. We
> > could also provide two completely separated codepaths with two setup
> > functions, and separate callbacks for each type - but I think that the
> > API structure of GtkTextView and GtkEditable is too similar to be split
> > apart.
> > Note that after fixing this issue we can also commit the patch for [2],
> > with updates that are probably necessary.
> > 
> > [1]
> > http://mail.gnome.org/archives/gtk-devel-list/2000-October/msg00241.html
> > [2] http://bugzilla.gnome.org/show_bug.cgi?id=95112
-- 
Christian Neumair <chris gnome-de org>