Re: [PATCH] Only show "Close Parent Windows" if we're not displaying a toplevel URI



On Thu, 2005-05-12 at 14:02 +0200, Christian Neumair wrote:
> >From http://bugzilla.gnome.org/show_bug.cgi?id=149287:
> 
> 
> Proposed patch (against HEAD).
> 
> - adds nautilus_file_has_parent
> - adds nautilus_window_(info_)update_menus, which is called when updating the
> menus and implemented by all subclasses of NautilusWindow

However, this is not. We don't want to "know" what all the various
nautilus_window_update_menus() versions do and call it whenever
something changes that affects these. For instance, the FMDirectoryView
place where you added the nautilus_window_update_menus call gets called
every time the selection changes, because the view code knows then that
the menus need to be updated. However, the NautilusWindow menu only
needs updating when the location changes.

The right thing to make the spatial window always update the sensitivity
when you change the location. Fortunately we already track all this for
the "up" button in navigational mode. So you just need to hook off
nautilus_window_allow_up().


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a maverick playboy romance novelist She's an artistic mutant detective 
who inherited a spooky stately manor from her late maiden aunt. They fight 
crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]