Re: Progress dialogs patch

From: "Jaap Haitsma" <jaap haitsma org>
To: "Martin Wehner" <martin wehner gmail com>
Cc: nautilus-list gnome org
Subject: Re: Progress dialogs patch
Date: Wed, 30 Mar 2005 19:35:23 +0200 (CEST)

> It leaked progress_title & remaining_time_string, used gchar
> instead of char and I removed the commented out stuff & white space
> changes.
>

Martin,

Most of the nautilus code use char i.s.o. gchar. The files you patched
only contain char I think. And acorrding to Alex gchar gint are spawn of
the devil [1]
So you might want to change gchar back to char ;-)

Jaap

[1] http://mail.gnome.org/archives/nautilus-list/2005-February/msg00095.html

Follow-Ups:
- Re: Progress dialogs patch
  - From: Martin Wehner

References:
- Progress dialogs patch
  - From: Michiel Sikkes
- Re: Progress dialogs patch
  - From: Martin Wehner

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]