[PATCH] Minor properties dialog simplifications



I found a couple things that I think could be cleaned up from the File
Properties dialog box

a) For normal files, both the proper-form MIME-Type, as well as a human
readable description are shown. The Mime type seems superfluous, except
perhaps to developers and a few advanced users who are working directly
with file types-- perhaps it would be better to have it as an extension?

b) The permissions tab, underneath the permission editing area shows
both an 'ls -l' format and an octal number permission display. These
both seem unnecessary, since the information is already available in the
editing widgets. 

--- /home/quinn/devel/cvs/gnome/nautilus/src/file-manager/fm-properties-window.c	2005-02-24 04:13:32.000000000 -0500
+++ src/file-manager/fm-properties-window.c	2005-03-17 02:49:32.438106630 -0500
@@ -2198,16 +2198,6 @@
 }
 
 static gboolean
-should_show_mime_type (FMPropertiesWindow *window) 
-{
-	if (file_list_all_directories (window->details->target_files)) {
-		return FALSE;
-	}
-
-	return TRUE;
-}
-
-static gboolean
 should_show_link_target (FMPropertiesWindow *window)
 {
 	if (!is_multi_file_window (window)
@@ -2360,12 +2350,6 @@
 						    _("--"),
 						    FALSE);
 	}
-	if (should_show_mime_type (window)) {
-		append_title_value_pair (window, table, _("MIME type:"), 
-					 "mime_type",
-					 _("--"),
-					 FALSE);
-	}				  
 	
 	/* Blank title ensures standard row height */
 	append_title_field (table, "", NULL);
@@ -3082,14 +3066,6 @@
 		append_special_execution_flags (window, page_table);
 		
 		append_title_value_pair
-			(window, page_table, _("Text view:"), 
-			 "permissions", _("--"),
-			 FALSE);
-		append_title_value_pair 
-			(window, page_table, _("Number view:"), 
-			 "octal_permissions", _("--"),
-			 FALSE);
-		append_title_value_pair
 			(window, page_table, _("Last changed:"), 
 			 "date_permissions", _("--"),
 			 FALSE);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]