Re: [PATCH] - Fix for 155928 -Adds GTK2 Bookmarks to Nautilus

[Jamie McCracken <jamiemcc blueyonder co uk>]

Alexander Larsson wrote:
> On Wed, 2005-06-22 at 17:40 +0200, Alexander Larsson wrote:
>
> > On Wed, 2005-06-22 at 13:48 +0100, Jamie McCracken wrote:
> >
> > > Its not that easy! :)
> > >
> > > That format is forwards compatible but not backwards compatible so 
> > > GTKFileChooser in 2.6 cant use that so I have to tread carefully.
> > >
> > > I have created a new patch that allows nautilus to use, edit and store 
> > > bookmarks in both formats. (I copied some of the code from gtk 2.7 so if 
> > > its buggy complain to them!)
> > >
> > > To prevent new format being written in Nautilus, the patch will make the 
> > > Name field in the bookmarks editing window insensitive if compiled with 
> > > -dUSING_GTK_2_6. This is the easiest way to do this without 
> > > changing/removing a whole load of code. I also had to add a flag to the 
> > > bookmarks to indicate whether it has a user defined name.
> >
> > Just use:
> > #include <gtk/gtkversion.h>
> > #if GTK_CHECK_VERSION(2,7,0)
> > in the code instead.
>
>
> Actually, matthias fixed Gtk 2.6 CVS to work with the new format.
> So, maybe we can just ignore this issue. Renaming bookmarks isn't gonna
> be that common anyway.

Well thats okay then - 2.11/2.12 can specify that GTK 2.6.? branch as a 
build requirement.

jamie.

> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  Alexander Larsson                                            Red Hat, Inc 
>                    alexl redhat com    alla lysator liu se 
> He's a fast talking moralistic sorceror on the edge. She's a supernatural 
> streetsmart Valkyrie with her own daytime radio talk show. They fight crime!