Re: [PATCH] Don't setup clipboard handling twice for the same widget

[Christian Neumair <chris gnome-de org>]

Am Donnerstag, den 02.06.2005, 10:35 +0200 schrieb Alexander Larsson:
> On Wed, 2005-06-01 at 19:56 +0200, Christian Neumair wrote:
> > Renaming a file while another rename is in progress causes breakage due
> > to twice setting up the same editing widget. The attached patch prevents
> > Nautilus from setting up clipboard handling for the same editing widget
> > twice.
> > We silently assume that the widget always stays in the same window. The
> > UI manager is not changed on reparenting.
> 
> Is this a fix for this crash i just got:
> 
> #0  0x0025f7a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
> #1  0x004c631b in __waitpid_nocancel () from /lib/tls/libpthread.so.0
> #2  0xb7d9488a in libgnomeui_segv_handle (signum=11) at gnome-ui-init.c:741
> #3  <signal handler called>
> #4  IA__gtk_ui_manager_remove_action_group (self=0xb790f1e4, action_group=0x0)
>     at gtkuimanager.c:667
> #5  0xb7f5463e in merge_out_clipboard_menu_items (widget_as_object=0x8a05ff4, 
>     target_data=0x8a862c0) at nautilus-clipboard.c:257
> #6  0xb7f54819 in focus_changed_callback (widget=0x8a05ff4, event=0x830d1dc, 
>     callback_data=0x8a862c0) at nautilus-clipboard.c:290
> [...]

Yes it is. 

> The patch looks pretty good. What if shares_selection_changes has
> different from the first call though?

That's another assumption we can currently make: The setup function for
the same editing widget will always have the same
shares_selection_changes argument. Also, I think this will once vanish,
because I see no reason why we couldn't sync up all editing widgets with
the clipboard. I'll look into it.

-- 
Christian Neumair <chris gnome-de org>