Re: worst dialog ever

[Luis Villa <luis villa gmail com>]

On 7/26/05, Christian Neumair <chris gnome-de org> wrote:
> Am Dienstag, den 26.07.2005, 15:44 -0400 schrieb Luis Villa:
> > On 7/26/05, Luis Villa <luis villa gmail com> wrote:
> > > On 7/26/05, Luis Villa <luis villa gmail com> wrote:
> > > > Grr. I've hated the 'these file types are mismatched' 'security'dialog
> > > > for a long time, because it is totally uninformative, gives a lot of
> > > > false positives, and makes it totally unclear how one is supposed to
> > > > recover from the error. I've finally found a case where it actually
> > > > *forces* me to use the terminal, though, which makes me hate it even
> > > > more.
> > > >
> > > > Situation:
> > > > * docbook extension is .xml
> > > > * install attached 'docbook.xml' in /usr/share/mime/packages/, run
> > > > 'update-mime-database /usr/share/mime/', kill gnome-vfs-daemon, and
> > > > restart nautilus.
> > > > * drop test.xml into, say, ~/Desktop/
> > > > * right click on properties of test.xml, note that (pleasurably) your
> > > > file is shown to be docbook, though you likely don't have any
> > > > docbook-specific handlers.
> > > > * double-click on the file.
> > > > * get the error message from hell, even though the file (1) has the
> > > > correct extension and (2) is properly sniffed by the properties
> > > > dialog.
> > > >
> > > > So... can we please finally kill this dialog? :) At the very least, it
> > > > has to be fixed to be able to accept that some extensions can be
> > > > multiple types of file.
> > > >
> > > > Luis (and yes, I'll add these details to the bug, but it has been
> > > > getting ignored a long time.)
> > >
> > > http://bugzilla.gnome.org/show_bug.cgi?id=310082
> >
> > Bah. http://bugzilla.gnome.org/show_bug.cgi?id=309862
> 
> Turns out that the way we determined whether this dialog should be shown
> was really scary. The attached patch handles all cases where the sniffed
> MIME type is either equal to the guessed one or inherits from it. Looks
> like when we introduced the dialog GnomeVFS was simply not powerful
> enough API-wise, but these times are gone - kudos to the brave VFS
> hackers :).

Woot. While Christian was writing this I was goaded into reading the
code; this is exactly the vfs API that I was about to write and ask
and see if it existed :) Thanks, Christian.

I've built and tested here, and it solves this particular corner case
perfectly, and I bet it fixes a lot of the nagging
ogg/vorbis/weirdness corner cases as well.

thanks-
Luis