[PATCH] info side pane text issues - consolidated patch

[Vincent Noel <vincent noel gmail com>]

Hey all,
here is a (small) consolidated patch that fixes the following issues
with the "informations" side pane :

bug 310386 : text in info side pane should be selectable [1]
bug 80429 : "Shortening the `Open with...' buttons in the sidebar" [2]
bug 43858: Document titles don't wrap in the sidebar. [3]

The patch adds ellipsizing to all elements (file name, file info and
buttons) and makes the relevant ones selectable. It's not perfect
(truncated file names are not ideal) but it looks way better than what
we have now.

Please comment.
Cheers
Vincent

[1] http://bugzilla.gnome.org/show_bug.cgi?id=310386
[2] http://bugzilla.gnome.org/show_bug.cgi?id=80429
[3] http://bugzilla.gnome.org/show_bug.cgi?id=43858

Index: src/nautilus-information-panel.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-information-panel.c,v
retrieving revision 1.230
diff -u -r1.230 nautilus-information-panel.c
--- src/nautilus-information-panel.c	28 Jun 2005 12:54:45 -0000	1.230
+++ src/nautilus-information-panel.c	14 Jul 2005 20:36:58 -0000
@@ -252,7 +252,7 @@
 	gtk_widget_show (GTK_WIDGET (information_panel->details->button_box));
 	gtk_box_pack_start (GTK_BOX (information_panel->details->button_box_centerer),
 			    GTK_WIDGET (information_panel->details->button_box),
-			    TRUE, FALSE, 0);
+			    TRUE, TRUE, 0);
 	information_panel->details->has_buttons = FALSE;
 }
 
@@ -886,17 +886,19 @@
 {
 	char *id_string, *temp_str;
 	GList *p;
-	GtkWidget *temp_button;
+	GtkWidget *temp_button, *label;
 	GnomeVFSMimeApplication *application;
 
 	/* There's always at least the "Open with..." button */
 	information_panel->details->has_buttons = TRUE;
 
-	for (p = application_list; p != NULL; p = p->next) {
+	for (p = application_list; p != NULL; p = p->next) {		
 	        application = p->data;	        
 
 		temp_str = g_strdup_printf (_("Open with %s"), application->name);
 	        temp_button = gtk_button_new_with_label (temp_str);
+		label = GTK_BIN (temp_button)->child;
+		gtk_label_set_ellipsize (GTK_LABEL (label), PANGO_ELLIPSIZE_START);
 		g_free (temp_str);
 		gtk_box_pack_start (GTK_BOX (information_panel->details->button_box), 
 				    temp_button, 
Index: src/nautilus-sidebar-title.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-sidebar-title.c,v
retrieving revision 1.151
diff -u -r1.151 nautilus-sidebar-title.c
--- src/nautilus-sidebar-title.c	13 Jul 2005 12:23:37 -0000	1.151
+++ src/nautilus-sidebar-title.c	14 Jul 2005 20:36:59 -0000
@@ -678,7 +677,10 @@
 	title_label = gtk_label_new ("");
 	eel_gtk_label_make_bold (GTK_LABEL (title_label));
 	gtk_label_set_line_wrap (GTK_LABEL (title_label), TRUE);
+	gtk_label_set_selectable (GTK_LABEL (title_label), TRUE);
 	gtk_label_set_justify (GTK_LABEL (title_label), GTK_JUSTIFY_CENTER);
+	gtk_label_set_ellipsize (GTK_LABEL (title_label), PANGO_ELLIPSIZE_END);
+	gtk_misc_set_alignment (GTK_MISC (title_label), 0., 0.5);
 
 	return title_label;
 }
@@ -691,6 +693,9 @@
 	more_info_label = gtk_label_new ("");
 	eel_gtk_label_set_scale (GTK_LABEL (more_info_label), PANGO_SCALE_SMALL);
 	gtk_label_set_justify (GTK_LABEL (more_info_label), GTK_JUSTIFY_CENTER);
+	gtk_label_set_selectable (GTK_LABEL (more_info_label), TRUE);
+	gtk_label_set_ellipsize (GTK_LABEL (more_info_label), PANGO_ELLIPSIZE_END);
+	gtk_misc_set_alignment (GTK_MISC (more_info_label), 0., 0.5);
 	
 	return more_info_label;
 }