Re: [PATCH] Fix pathbar history issue

[Alexander Larsson <alexl redhat com>]

On Wed, 2005-07-13 at 13:47 +0200, Christian Neumair wrote:
> Am Mittwoch, den 13.07.2005, 13:33 +0200 schrieb Alexander Larsson:
> > On Tue, 2005-07-12 at 17:36 +0200, Christian Neumair wrote:
> > > From bug 310068 [1]:
> > > 
> > > "Steps to reproduce the problem:
> > > 1. Enter a folder with lots of stuff in it so that the scroll bar
> > > appears
> > > 2. Scroll down a bit, then enter a sub-folder
> > > 3. Use the path bar to go back to the previous folder
> > > 
> > > Actual Results:
> > > Scroll bar is at the beginning ot the parent folder.
> > > 
> > > Expected Results:
> > > Scroll bar is at the position I scrolled to prior to entering the
> > > sub-folder."
> > > 
> > > Proposed patch attached. I've fixed this by treating a pathbar location
> > > change as back action if the target location is in the history.
> > 
> > +       bookmark = nautilus_bookmark_new (uri, "foo");
> > 
> > Creating a bookmark like that does all sorts of i/o, which can cause
> > authentication and whatnot on a too early state. Instead, just get the
> > uri from the bookmark and compare it.
> 
> I didn't realize that the involved backend is *that* complex (GnomeVFS
> etc.). I wanted to make this code run optimal for big numbers of
> bookmarks.

Looks good. Please commit with a ChangeLog entry.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a fiendish white trash vampire hunter with nothing left to lose. She's a 
high-kicking Buddhist safe cracker with an incredible destiny. They fight 
crime!