Re: Leak and strange code in nautilus-file.c



fre, 28,.01.2005 kl. 15.42 +0100, skrev Alexander Larsson:
> On Thu, 2005-01-27 at 12:31 +0100, Alexander Larsson wrote:
> > 
> > I don't understand how this could leak.
> > file->details->cached_display_name should always be freed when the
> > file
> > is freed.
> > 
> > Also, i don't understand your problem with
> > nautilus_file_display_name_nocopy(). It never sets name if its already
> > been set to non-NULL in the function, except in one place where we
> > free
> > it first.
> 
> crispin on irc pointed out the leak. Should be fixed now.
> 
Very good. Sorry for not following up on that right away, and nice to
see that I wasn't totally off target :-)

Cheers
Kjartan





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]