Re: [PATCH]: Show icon on Open with page

[Martin Wehner <martin wehner epost de>]

On Fri, 2005-01-21 at 14:53 +0100, Fernando Herrera wrote:
> Hello
> 
>    Attached patch changes eel to show the application icon in the Open
> With selector.
>    Notice that it's getting the icon from the .desktop file, and only
> applications added after with recent eel are creating a full .dekstop
> file (with the icon field).
> 
> Salu2
> 

When I apply this patch, Nautilus crashes every time when I try to view
the properties of a file (which has an associated application).

Console spews:

(nautilus:7383): GLib-CRITICAL **: g_path_is_absolute: assertion
`file_name != NULL' failed

(nautilus:7383): Gtk-CRITICAL **: gtk_icon_theme_load_icon: assertion
`icon_name != NULL' failed

I've attached the juicy bits of the stack trace.

Martin

0x001017a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
#0  0x001017a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2
#1  0x0024a42b in __waitpid_nocancel () from /lib/tls/libpthread.so.0
#2  0x002b6852 in libgnomeui_segv_handle (signum=11) at gnome-ui-init.c:741
#3  <signal handler called>
#4  0x05680de3 in strrchr () from /lib/tls/libc.so.6
#5  0x00f6d95f in refresh_model (chooser=0xa00de00) at eel-mime-application-chooser.c:428
#6  0x00f6dfea in eel_mime_application_chooser_new (uri=0xa00d8a8 "file:///home/user/ugly.jpg", mime_type=0xa00d8e0 "image/jpeg")
    at eel-mime-application-chooser.c:539
#7  0x080a814e in create_open_with_page (window=0x9fb47a0) at fm-properties-window.c:3288
#8  0x080a9043 in create_properties_window (startup_data=0x0) at fm-properties-window.c:3397
#9  0x080a92ab in is_directory_ready_callback (file=0x9fa0960, data=0x9fb5db0) at fm-properties-window.c:3550
#10 0x0080a33d in ready_callback_call (directory=0x9eeb9f0, callback=0x9fbc998) at nautilus-directory-async.c:1262
#11 0x0080b9b3 in nautilus_directory_async_state_changed (directory=0x9eeb9f0) at nautilus-directory-async.c:1895
#12 0x0080e16d in nautilus_directory_call_when_ready_internal (directory=0x9eeb9f0, file=0x9fa0960, 
    file_attributes=NAUTILUS_FILE_ATTRIBUTE_IS_DIRECTORY, wait_for_file_list=0, directory_callback=0, 
    file_callback=0x80a9268 <is_directory_ready_callback>, callback_data=0x0) at nautilus-directory-async.c:1344
#13 0x0084b4da in vfs_file_call_when_ready (file=0x0, file_attributes=NAUTILUS_FILE_ATTRIBUTE_IS_DIRECTORY, 
    callback=0x80a9268 <is_directory_ready_callback>, callback_data=0x9fb5db0) at nautilus-vfs-file.c:66
#14 0x008248cc in nautilus_file_call_when_ready (file=0x9fa0960, file_attributes=NAUTILUS_FILE_ATTRIBUTE_IS_DIRECTORY, 
    callback=0x80a9268 <is_directory_ready_callback>, callback_data=0x9fb5db0) at nautilus-file.c:5484
#15 0x080a983d in fm_properties_window_present (original_files=0x9f35ec4, parent_widget=0x9ee7e88) at fm-properties-window.c:3640
#16 0x0808bc3c in action_properties_callback (action=0x9f00fd8, callback_data=0x9ee7e88) at fm-directory-view.c:1111
#17 0x009aeed7 in IA__g_cclosure_marshal_VOID__VOID (closure=0x9f00f08, return_value=0x0, n_param_values=1, param_values=0x0, 
    invocation_hint=0xbff79dc8, marshal_data=0x0) at gmarshal.c:77
#18 0x0099ad29 in IA__g_closure_invoke (closure=0x9f00f08, return_value=0x0, n_param_values=1, param_values=0xbff79ee0, 
    invocation_hint=0xbff79dc8) at gclosure.c:437
#19 0x009ad94a in signal_emit_unlocked_R (node=0x9ea0880, detail=0, instance=0x9f00fd8, emission_return=0x0, instance_and_params=0xbff79ee0)
    at gsignal.c:2485
#20 0x009ae8d0 in IA__g_signal_emit_valist (instance=0x9f00fd8, signal_id=1, detail=0, var_args=0xbff7a06c "") at gsignal.c:2244
#21 0x009aeb1c in IA__g_signal_emit (instance=0x9f00fd8, signal_id=131, detail=0) at gsignal.c:2288
#22 0x0045c032 in _gtk_action_emit_activate (action=0x9f00fd8) at gtkaction.c:1010
#23 0x0045c565 in IA__gtk_action_activate (action=0x9f00fd8) at gtkaction.c:1037
#24 0x009aeed7 in IA__g_cclosure_marshal_VOID__VOID (closure=0x9f24d78, return_value=0x0, n_param_values=1, param_values=0x0, 
    invocation_hint=0xbff7a218, marshal_data=0x0) at gmarshal.c:77
#25 0x0099ad29 in IA__g_closure_invoke (closure=0x9f24d78, return_value=0x0, n_param_values=1, param_values=0xbff7a330, 
    invocation_hint=0xbff7a218) at gclosure.c:437
#26 0x009ad94a in signal_emit_unlocked_R (node=0x9ea9db0, detail=0, instance=0x9f24cd8, emission_return=0x0, instance_and_params=0xbff7a330)
    at gsignal.c:2485
#27 0x009ae8d0 in IA__g_signal_emit_valist (instance=0x9f24cd8, signal_id=1, detail=0, var_args=0xbff7a4bc "") at gsignal.c:2244
#28 0x009aeb1c in IA__g_signal_emit (instance=0x9f24cd8, signal_id=149, detail=0) at gsignal.c:2288
#29 0x005e08c4 in IA__gtk_widget_activate (widget=0x9f24cd8) at gtkwidget.c:3647
#30 0x0051ee09 in IA__gtk_menu_shell_activate_item (menu_shell=0x9f19000, menu_item=0x9f24cd8, force_deactivate=1) at gtkmenushell.c:943
#31 0x0051f0a3 in gtk_menu_shell_button_release (widget=0x9f19000, event=0x9ec08a8) at gtkmenushell.c:556
#32 0x005169ad in gtk_menu_button_release (widget=0x9f19000, event=0x9ec08a8) at gtkmenu.c:2548
#33 0x00511d1d in _gtk_marshal_BOOLEAN__BOXED (closure=0x9e8fe98, return_value=0xbff7a6c0, n_param_values=2, param_values=0xbff7a800, 
    invocation_hint=0xbff7a6e8, marshal_data=0x516958) at gtkmarshalers.c:83
#34 0x0099af8d in g_type_class_meta_marshal (closure=0x9e8fe98, return_value=0xbff7a6c0, n_param_values=2, param_values=0xbff7a800, 
    invocation_hint=0xbff7a6e8, marshal_data=0x0) at gclosure.c:514
#35 0x0099ad29 in IA__g_closure_invoke (closure=0x9e8fe98, return_value=0xbff7a6c0, n_param_values=2, param_values=0xbff7a800, 
    invocation_hint=0xbff7a6e8) at gclosure.c:437
#36 0x009ad4ba in signal_emit_unlocked_R (node=0x9e900e0, detail=0, instance=0x9f19000, emission_return=0xbff7a790, 
    instance_and_params=0xbff7a800) at gsignal.c:2523
#37 0x009ae60d in IA__g_signal_emit_valist (instance=0x9f19000, signal_id=0, detail=0, var_args=0xbff7a990 "�������t^")
    at gsignal.c:2254
#38 0x009aeb1c in IA__g_signal_emit (instance=0x9f19000, signal_id=65, detail=0) at gsignal.c:2288
#39 0x005e0a12 in gtk_widget_event_internal (widget=0x9f19000, event=0x9ec08a8) at gtkwidget.c:3616
#40 0x005105c3 in IA__gtk_propagate_event (widget=0x9f19000, event=0x9ec08a8) at gtkmain.c:2145
#41 0x00510890 in IA__gtk_main_do_event (event=0x9ec08a8) at gtkmain.c:1383
#42 0x007263be in gdk_event_dispatch (source=0x0, callback=0, user_data=0x0) at gdkevents-x11.c:2220
#43 0x00a01d71 in IA__g_main_context_dispatch (context=0x9e02d70) at gmain.c:1947
#44 0x00a0364f in g_main_context_iterate (context=0x9e02d70, block=1, dispatch=1, self=0x9de2380) at gmain.c:2578
#45 0x00a038d0 in IA__g_main_loop_run (loop=0x9e8c9a8) at gmain.c:2782
#46 0x0050fd73 in IA__gtk_main () at gtkmain.c:963
#47 0x080750c1 in main (argc=1, argv=0xbff7adb4) at nautilus-main.c:353