Re: [PATCH] Remove Open with dialog from properties page of Trash

[Stephen Browne <Stephen Browne Sun COM>]

Jaap, Alex,

If you are looking at this can you also disable the open with tab if the
mime type of the file is application/x-desktop (or whatever the 
.desktop file mime type is)?

It doesn't make sense to associate applications with these right?

Apologies for not hacking up the patch myself :/

Stephen.


On Thu, 2005-02-17 at 09:42, Alexander Larsson wrote:
> On Wed, 2005-02-16 at 23:55 +0100, Jaap Haitsma wrote:
> > Currently when you decide to show the properties page of the trash you 
> > get the following console messages
> > 
> > (nautilus:4657): libgnomevfs-CRITICAL **: 
> > gnome_vfs_uri_extract_short_path_name: assertion `uri != NULL' failed
> > 
> > (nautilus:4657): libgnomevfs-CRITICAL **: gnome_vfs_uri_get_host_name: 
> > assertion `uri != NULL' failed
> > 
> > (nautilus:4657): libgnomevfs-CRITICAL **: gnome_vfs_uri_get_path: 
> > assertion `uri != NULL' failed
> > 
> > (nautilus:4657): Eel-WARNING **: No extension, not implemented yet
> > 
> > This is caused by the Open With tab in the properties page. Furthermore 
> > the open with functionality also does not work for the trash and to me 
> > it doesn't make much sense either.
> > 
> > Attached patch removes Open With Dialog when properties of the Trash are 
> > shown.
> 
>    if (!is_multi_file_window (window)
> +           && nautilus_file_is_symbolic_link (get_target_file (window))) {
> +               return TRUE;
> +       }
> 
> 
> Doesn't this only display it for symbolic links? Its certainly not
> something that only affects trash:///.
> 
> 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  Alexander Larsson                                            Red Hat, Inc 
>                    alexl redhat com    alla lysator liu se 
> He's a scrappy small-town gangster moving from town to town, helping folk in 
> trouble. She's a pregnant impetuous opera singer fleeing from a Satanic cult. 
> They fight crime! 
> 
> -- 
> nautilus-list mailing list
> nautilus-list gnome org
> http://mail.gnome.org/mailman/listinfo/nautilus-list