[PATCH] Remove Open with dialog from properties page of Trash

[Jaap Haitsma <jaap haitsma org>]

Currently when you decide to show the properties page of the trash you 
get the following console messages

(nautilus:4657): libgnomevfs-CRITICAL **: 
gnome_vfs_uri_extract_short_path_name: assertion `uri != NULL' failed

(nautilus:4657): libgnomevfs-CRITICAL **: gnome_vfs_uri_get_host_name: 
assertion `uri != NULL' failed

(nautilus:4657): libgnomevfs-CRITICAL **: gnome_vfs_uri_get_path: 
assertion `uri != NULL' failed

(nautilus:4657): Eel-WARNING **: No extension, not implemented yet

This is caused by the Open With tab in the properties page. Furthermore 
the open with functionality also does not work for the trash and to me 
it doesn't make much sense either.

Attached patch removes Open With Dialog when properties of the Trash are 
shown.


Jaap

Index: fm-properties-window.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/file-manager/fm-properties-window.c,v
retrieving revision 1.208
diff -u -r1.208 fm-properties-window.c
--- fm-properties-window.c	7 Feb 2005 23:08:21 -0000	1.208
+++ fm-properties-window.c	16 Feb 2005 22:48:38 -0000
@@ -3282,7 +3282,15 @@
 static gboolean
 should_show_open_with (FMPropertiesWindow *window)
 {
-	return !is_multi_file_window (window);
+	/* Don't show open with for the Trash since it's not
+	 * really a file system object.
+	 */
+	if (!is_multi_file_window (window)
+	    && nautilus_file_is_symbolic_link (get_target_file (window))) {
+		return TRUE;
+	}
+
+	return FALSE;
 }
 
 static void