Re: [PATCH] Replace GtkOptionMenu with GtkComboBox in file properties dialog
- From: Alexander Larsson <alexl redhat com>
- To: Jaap Haitsma <jaap haitsma org>
- Cc: "nautilus-list gnome org" <nautilus-list gnome org>
- Subject: Re: [PATCH] Replace GtkOptionMenu with GtkComboBox in file properties dialog
- Date: Mon, 12 Dec 2005 10:29:34 +0100
On Sat, 2005-12-10 at 17:22 +0100, Jaap Haitsma wrote:
> There's an updated patch at http://bugzilla.gnome.org/show_bug.cgi?id=322567
> It should incorporate all your remarks
>
>
> > Also, why the change in nautilus_get_user_names? You still have to split
> > and stuff in the code. I think spaces are not allowed in usernames, so
> > it should be safe. However, I don't think its necessary, and a bit
> > strange.
>
> That way I did not need to do any splitting when populating the
> combobox. Any way the updated patch does not change nautilus_get_user_names
There was another place where we should ref the file. I added that and
commited. Thanks.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a fast talking arachnophobic photographer who dotes on his loving old ma.
She's a ditzy foul-mouthed journalist with a song in her heart and a spring in
her step. They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]