Re: nautilus code freeze break request

[Frederic Crozat <fcrozat mandrakesoft com>]

Le jeudi 02 septembre 2004 à 16:33 +0100, Mark McLoughlin a écrit :
> Hi Alex,
> 	Welcome back to our No. 1 customer! We'll have to start giving you a
> volume discount or something ...
> 
> On Thu, 2004-09-02 at 15:13, Alexander Larsson wrote:
> > I just found a pretty bad crasher bug in the nautilus metadata system.
> > It must have been there for ages. It is sort of racy, so its not that
> > easy to reproduce for local files, but it was easy for e.g. webdav.
> > 
> > The fix is pretty obvious if you look at the code:
> > 
> > Index: libnautilus-private/nautilus-metafile.c
> > ===================================================================
> > RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-metafile.c,v
> > retrieving revision 1.37
> > diff -u -p -r1.37 nautilus-metafile.c
> > --- libnautilus-private/nautilus-metafile.c	28 Feb 2003 15:15:00 -0000	1.37
> > +++ libnautilus-private/nautilus-metafile.c	2 Sep 2004 14:08:33 -0000
> > @@ -1486,7 +1486,7 @@ remove_file_metadata (NautilusMetafile *
> >  			if (found) {
> >  				g_hash_table_remove (hash, file_name);
> >  				g_free (key);
> > -				metadata_value_destroy (value);
> > +				destroy_metadata_changes_hash_table (value);
> 
> 	From your "Holy crap!" comments on irc about this one, I'm assuming its
> pretty serious and the fix is obvious, so ... :-)
> 
> 	Approval 1 of 2.

Approval 2 of 2..


-- 
Frederic Crozat <fcrozat mandrakesoft com>
Mandrakesoft