nautilus code freeze break request
- From: Alexander Larsson <alexl redhat com>
- To: Nautilus <nautilus-list gnome org>, "release-team gnome org" <release-team gnome org>
- Cc:
- Subject: nautilus code freeze break request
- Date: Thu, 02 Sep 2004 16:13:05 +0200
I just found a pretty bad crasher bug in the nautilus metadata system.
It must have been there for ages. It is sort of racy, so its not that
easy to reproduce for local files, but it was easy for e.g. webdav.
The fix is pretty obvious if you look at the code:
Index: libnautilus-private/nautilus-metafile.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-metafile.c,v
retrieving revision 1.37
diff -u -p -r1.37 nautilus-metafile.c
--- libnautilus-private/nautilus-metafile.c 28 Feb 2003 15:15:00 -0000 1.37
+++ libnautilus-private/nautilus-metafile.c 2 Sep 2004 14:08:33 -0000
@@ -1486,7 +1486,7 @@ remove_file_metadata (NautilusMetafile *
if (found) {
g_hash_table_remove (hash, file_name);
g_free (key);
- metadata_value_destroy (value);
+ destroy_metadata_changes_hash_table (value);
}
}
}
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a sword-wielding white trash gentleman spy on the hunt for the last
specimen of a great and near-mythical creature. She's a manipulative
hypochondriac angel on the trail of a serial killer. They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]