Re: [PATCH] Bug#153055 - user name in "Connect to Server" dialog box is not escaped

[Alexander Larsson <alexl redhat com>]

On Wed, 2004-09-29 at 09:10 -0400, Michael Henson wrote:
> On Mon, 2004-09-27 at 17:17 +0200, Alexander Larsson wrote:
> >
> > Username escaping is indeed a problem in many many places in gnome-vfs
> > and nautilus. Making this work everywhere will require lots of code
> > inspection and making sure everything handles this in the correct way.
> > 
> 
> Would it make sense to open an umbrella bug to help track the
> occurrences of these handling errors?

Yes. I've put it of for some time because its such a huge undertaking.

> I have also found a relevent patche to gnome-vfs that should resolve the
> decoding issues at that level: http://bugzilla.gnome.org/show_bug.cgi?
> id=89106

I don't like that patch, because it changes the current API/ABI that
many places in the code rely on. And we can't change
gnome_vfs_uri_get_user_name(), because that doesn't return a malloced
copy. :(

> > The path escaping looks strange. Why can't you just use
> > gnome_vfs_escape_path_string()?
> > 
> 
> I have updated the patch to use gnome_vfs_escape_path_string ().

Looks good. I commited this. (I removed some imho unnecessary blank
lines.)

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a deeply religious flyboy vagrant searching for his wife's true killer. 
She's a violent blonde Valkyrie prone to fits of savage, blood-crazed rage. 
They fight crime!