Re: [PATCH] nautilus bugzilla #160224

[Alexander Larsson <alexl redhat com>]

On Thu, 2004-12-16 at 12:33 +0530, Vijaykumar Patwari wrote:
> Hi All,
> 
> Problem
> -----------
> Nautilus crashes while opening bookmarks.
> 
> Open nautilus and browse through the folders. Bookmark the browsed path 
> (Go to `Bookmarks->Add Bookmark`). Go to `Bookmarks->Edit Bookmark`. 
> 'Edit Bookmark' window pops up. Close the Opened nautilus window.
> 
> `Edit Bookmark` dialog still exists, it does not gets destroyed along 
> with the parent window.
> 
> Now, Select the newly created bookmark from `Edit Bookmark` dialog and 
> click on 'jumpto' button.
> 
> Nautilus crashes.
> 
> Analysis
> -----------
> When nautilus window is closed, the Edit Bookmarks dialog was still 
> holding a reference of the parent window (i.e already destroyed window). 
> So, when 'Jumpto' button was clicked, it used the reference of the 
> previously destroyed window to open the bookmark. Hence the crash.
> 
> Have added the patch, which fixes the crash.
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=16022_4_
>       
> Please review the patch added in bugzilla.

Looks good. I commited it to cvs. Thanks for the patch.

     
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scarfaced chivalrous gangster possessed of the uncanny powers of an 
insect. She's a mentally unstable bisexual safe cracker with the power to see 
death. They fight crime!