eel input focus patch



Havoc just told me that using RevertToNone in XSetInputFocus is bad,
since that means you can lose the input focus. hp knows the details of
this. Is this ok to commit?

Index: eel/eel-gdk-extensions.c
===================================================================
RCS file: /cvs/gnome/eel/eel/eel-gdk-extensions.c,v
retrieving revision 1.20
diff -u -p -r1.20 eel-gdk-extensions.c
--- eel/eel-gdk-extensions.c    2 Oct 2002 05:17:57 -0000       1.20
+++ eel/eel-gdk-extensions.c    2 Sep 2003 14:54:55 -0000
@@ -642,7 +642,7 @@ eel_gdk_window_focus (GdkWindow *window,
        gdk_error_trap_push ();
        XSetInputFocus (GDK_DISPLAY (),
                        GDK_WINDOW_XWINDOW (window),
-                       RevertToNone,
+                       RevertToPointerRoot,
                        timestamp);
        gdk_flush();
        gdk_error_trap_pop ();

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a witless amnesiac romance novelist with nothing left to lose. She's a 
radical hip-hop traffic cop with the power to bend men's minds. They fight 
crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]