Re: [PATCH] Misc. fixes for libeel

[Gregory Merchan <merchan phys lsu edu>]

Oops. Forgot the patch.

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/eel/ChangeLog,v
retrieving revision 1.574
diff -p -u -r1.574 ChangeLog
--- ChangeLog	22 Oct 2003 07:54:18 -0000	1.574
+++ ChangeLog	24 Oct 2003 02:50:45 -0000
@@ -1,3 +1,20 @@
+2003-10-23  Gregory Merchan  <merchan phys lsu edu>
+
+	* eel/eel-gdk-extensions.c (eel_gdk_window_focus):
+	Use RevertToParent as specified in the ICCCM.
+	(eel_gdk_window_set_wm_hints_input):
+	Guard against changes to C booleans.
+	* eel/eel-gnome-extensions.c (eel_gnome_icon_selector_new)
+	* eel/eel-stock-dialogs.c (timed_wait_callback)
+	* eel/eel-stock-dialogs.c (eel_run_simple_dialog)
+	* eel/eel-stock-dialogs.c (create_message_dialog)
+	Don't set WM_CLASS. It should match the application.
+	* eel/eel-gtk-extensions.c:
+	Remove comment and unused #define from bad old algorithm.
+	(eel_gtk_window_event_is_close_accelerator):
+	Remove Escape from close accelerators; it's not HIG compliant.
+	This reverts change from 2001-04-30.
+
 2003-10-22  Alexander Larsson  <alexl redhat com>
 
 	* eel/Makefile.am: 
Index: eel/eel-gdk-extensions.c
===================================================================
RCS file: /cvs/gnome/eel/eel/eel-gdk-extensions.c,v
retrieving revision 1.21
diff -p -u -r1.21 eel-gdk-extensions.c
--- eel/eel-gdk-extensions.c	4 Sep 2003 12:12:19 -0000	1.21
+++ eel/eel-gdk-extensions.c	24 Oct 2003 02:50:46 -0000
@@ -642,7 +642,7 @@ eel_gdk_window_focus (GdkWindow *window,
 	gdk_error_trap_push ();
 	XSetInputFocus (GDK_DISPLAY (),
 			GDK_WINDOW_XWINDOW (window),
-			RevertToPointerRoot,
+			RevertToParent,
 			timestamp);
 	gdk_flush();
 	gdk_error_trap_pop ();
@@ -691,7 +691,7 @@ eel_gdk_window_set_wm_hints_input (GdkWi
 	}
 
 	wm_hints->flags |= InputHint;
-	wm_hints->input = status;
+	wm_hints->input = (status == FALSE) ? False : True;
 
 	XSetWMHints (dpy, id, wm_hints);
 	XFree (wm_hints);
Index: eel/eel-gnome-extensions.c
===================================================================
RCS file: /cvs/gnome/eel/eel/eel-gnome-extensions.c,v
retrieving revision 1.44
diff -p -u -r1.44 eel-gnome-extensions.c
--- eel/eel-gnome-extensions.c	5 Feb 2003 18:30:32 -0000	1.44
+++ eel/eel-gnome-extensions.c	24 Oct 2003 02:50:46 -0000
@@ -414,7 +414,6 @@ eel_gnome_icon_selector_new (const char 
 	if (owner != NULL) {
 		gtk_window_set_transient_for (GTK_WINDOW (dialog), owner);
  	}
- 	gtk_window_set_wmclass (GTK_WINDOW (dialog), "file_selector", "Eel");
 	gtk_widget_show_all (dialog);
 	
 	entry = gnome_file_entry_gtk_entry (GNOME_FILE_ENTRY (file_entry));
Index: eel/eel-gtk-extensions.c
===================================================================
RCS file: /cvs/gnome/eel/eel/eel-gtk-extensions.c,v
retrieving revision 1.53
diff -p -u -r1.53 eel-gtk-extensions.c
--- eel/eel-gtk-extensions.c	2 Oct 2002 05:17:57 -0000	1.53
+++ eel/eel-gtk-extensions.c	24 Oct 2003 02:50:47 -0000
@@ -67,11 +67,6 @@
 #define MINIMUM_ON_SCREEN_WIDTH		100
 #define MINIMUM_ON_SCREEN_HEIGHT	100
 
-/* How far down the window tree will we search when looking for top-level
- * windows? Some window managers doubly-reparent the client, so account
- * for that, and add some slop.
- */
-#define MAXIMUM_WM_REPARENTING_DEPTH 4
 
 /**
  * eel_gtk_button_new_with_stock_icon:
@@ -261,9 +256,6 @@ eel_gtk_window_event_is_close_accelerato
 		}
 	}
 
-	if (event->keyval == GDK_Escape) {
-		return TRUE;
-	}
 
 	return FALSE;	
 }
Index: eel/eel-stock-dialogs.c
===================================================================
RCS file: /cvs/gnome/eel/eel/eel-stock-dialogs.c,v
retrieving revision 1.23
diff -p -u -r1.23 eel-stock-dialogs.c
--- eel/eel-stock-dialogs.c	12 Mar 2003 05:46:02 -0000	1.23
+++ eel/eel-stock-dialogs.c	24 Oct 2003 02:50:48 -0000
@@ -232,7 +232,6 @@ timed_wait_callback (gpointer callback_d
 	gtk_window_set_default_size (GTK_WINDOW (dialog),
 				     TIMED_WAIT_MINIMUM_DIALOG_WIDTH,
 				     -1);
-	gtk_window_set_wmclass (GTK_WINDOW (dialog), "dialog", "Eel");
 	add_label_to_dialog (dialog, wait->wait_message);
 	wait->dialog_creation_time = eel_get_system_time ();
 	gtk_widget_show_all (GTK_WIDGET (dialog));
@@ -366,7 +365,6 @@ eel_run_simple_dialog (GtkWidget *parent
 	}
 	va_end (button_title_args);
 	
-	gtk_window_set_wmclass (GTK_WINDOW (dialog), "dialog", "Eel");
 
 	/* Title it if asked to. */
 	add_label_to_dialog (GTK_DIALOG (dialog), text);
@@ -396,7 +394,6 @@ create_message_dialog (const char *messa
 
 	box = gtk_message_dialog_new (parent, 0, type, buttons_type, "%s", message);
 	gtk_window_set_title (GTK_WINDOW (box), dialog_title);
-	gtk_window_set_wmclass (GTK_WINDOW (box), "stock_dialog", "Eel");
 	
 	return GTK_DIALOG (box);
 }