Re: HP-UX 11i compile failures

[Alexander Larsson <alexl redhat com>]

On Fri, 18 Oct 2002, Albert Chin wrote:

> On Fri, Oct 18, 2002 at 05:38:52AM -0400, Alexander Larsson wrote:
> > On Wed, 16 Oct 2002, Albert Chin wrote:
> > 
> > > Attempting to build 2.0.7 with the HP C compiler on 11i:
> > > cc: "nautilus-directory-async.c", line 1232: error 1721: Operands for
> > > < must be of arithmetic type or pointers to compatible types.
> > > cc: "nautilus-directory-async.c", line 1232: error 1563: Expression in
> > > if must be scalar.
> > > cc: "nautilus-directory-async.c", line 1235: error 1721: Operands for
> > > > must be of arithmetic type or pointers to compatible types.
> > > cc: "nautilus-directory-async.c", line 1235: error 1563: Expression
> > > > in if must be scalar.
> > > cc: "nautilus-directory-async.c", line 1239: error 1721: Operands
> > > > for < must be of arithmetic type or pointers to compatible types.
> > > cc: "nautilus-directory-async.c", line 1239: error 1563: Expression
> > > > in if must be scalar.
> > > cc: "nautilus-directory-async.c", line 1242: error 1721: Operands
> > > > for > must be of arithmetic type or pointers to compatible types.
> > > cc: "nautilus-directory-async.c", line 1242: error 1563: Expression
> > > > in if must be scalar.
> > > gmake[2]: *** [nautilus-directory-async.lo] Error 1
> > > gmake[2]: Leaving directory
> > > `/opt/build/nautilus-2.0.7/libnautilus-private'
> > > 
> > > Problematic code:
> > >                 if (callback_a->callback.directory < callback_b->callback.directory) {
> > >                         return -1;
> > >                 }
> > >                 if (callback_a->callback.directory > callback_b->callback.directory) { 
> > >                         return 1;
> > >                 }
> > > 
> > > Should I cast to fix?
> > 
> > I'll let my commit speak for itself:
> 
> Thanks. That fixes it. However, you also need to apply the fix a few
> lines down for:
>   if (callback_a->callback.file < callback_b->callback.file) {

Oh. Thanks.
 
> I think your verbage in the patch is overly harsh though. Being more
> C89-compliant makes GNOME more portable to the likes of Tru64 UNIX,
> IRIX, and Solaris, most of whom have vendor compilers that, by
> default, are far more pedantic than GCC. I consider this a good thing.

Well. It isn't actually more compliant. On a (to my knowledge basically 
non-existing) architecture where function pointers are not ordered it will 
not work.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an underprivileged Jewish master criminal moving from town to town, 
helping folk in trouble. She's a hard-bitten psychic bodyguard from out of 
town. They fight crime!