Re: [patch] gladified fm-properties-window (updated)

[Alexander Larsson <alexl redhat com>]

On 11 Nov 2002, Jan Arne Petersen wrote:

> Hi,
> 
> I gladified the fm-properties-window. The gladified version should
> comply with the HIG.

I don't like parts of this change, although some of it are good.

Setting the window icon and changing it back to a GtkWindow is very good.

I wasn't able to actually open widgets in the glade file with glade-2 
(due to the usage of EelEllipsizeLabel), so I don't see the point in using 
glade. 

For the UI changes, In the "basic" page I think the placement of the name, 
icon and icon buttons are better in the original UI. The file information 
and access date changes are more HIG-like I guess, so thats good. Although 
the "Access Date" title seems a bit random, since it only describes one of 
its entries.  

On the "permissions" page I don't see the point of the option menu for the 
file owner name. That being insensitive just makes it harder to read. We 
also lost text/number-view and Last changed. The number view is pretty 
cracky, but I can see the text view being somewhat useful (as that is 
what ls normally gives), and the Last changed date could certainly be 
useful. 

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a war-weary albino librarian with acid for blood. She's a mentally 
unstable hypochondriac cab driver on her way to prison for a murder she didn't 
commit. They fight crime!